Skip to content

test: avoid truncating watched worker deps#63083

Open
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-test-watch-mode-worker
Open

test: avoid truncating watched worker deps#63083
inoway46 wants to merge 1 commit intonodejs:mainfrom
inoway46:fix-test-watch-mode-worker

Conversation

@inoway46
Copy link
Copy Markdown
Contributor

@inoway46 inoway46 commented May 2, 2026 •
edited
Loading

This fixes a flaky sequential/test-watch-mode-worker failure where the nested CJS worker dependency case can log {} instead of sub-dep v1.

The test rewrites watched worker dependency files to trigger --watch restarts, but default writeFileSync() temporarily truncates the file. A restarted worker can read the dependency during that empty-file window.

This change keeps the write-based restart trigger, but uses r+ to overwrite without truncation.

Reported in: https://github.com/nodejs/reliability/blob/main/reports/2026-05-02.md

not ok 5323 sequential/test-watch-mode-worker
  ---
  Test failure: 'should watch changes to nested worker dependencies - cjs'
  AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
    [
      'sub-dep v1',
      "Completed running '/home/iojs/node-tmp/.tmp.5322/2.js'. Waiting for file changes before restarting...",
      "Restarting '/home/iojs/node-tmp/.tmp.5322/2.js'",
  +   '{}',
  -   'sub-dep v1',
      "Completed running '/home/iojs/node-tmp/.tmp.5322/2.js'. Waiting for file changes before restarting..."
    ]

Testing:

$ ./tools/test.py sequential/test-watch-mode-worker

$ ./tools/test.py -j1 --repeat 20 sequential/test-watch-mode-worker

Refs: #62368

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 2, 2026
@inoway46 inoway46 force-pushed the fix-test-watch-mode-worker branch from b27b615 to da136db Compare May 2, 2026 14:44
@inoway46 inoway46 changed the title test: fix flaky test-watch-mode-worker test: avoid truncating watched worker deps May 2, 2026
@inoway46
test: avoid truncating watched worker deps
cfcd3e7 
Signed-off-by: inoway46 <inoueyuya416@gmail.com>
@inoway46 inoway46 force-pushed the fix-test-watch-mode-worker branch from da136db to cfcd3e7 Compare May 2, 2026 14:54
@inoway46 inoway46 marked this pull request as ready for review May 2, 2026 14:57
@codecov
Copy link
Copy Markdown

codecov Bot commented May 2, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (13e90d0) to head (cfcd3e7).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #63083      +/-   ##
==========================================
- Coverage   91.49%   89.65%   -1.84%     
==========================================
  Files         360      712     +352     
  Lines      151674   220498   +68824     
  Branches    23919    42278   +18359     
==========================================
+ Hits       138772   197685   +58913     
- Misses      12625    14664    +2039     
- Partials      277     8149    +7872

see 475 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLow MoLow MoLow approved these changes

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@inoway46 @MoLow @nodejs-github-bot